notification of new listener email missing link

Submitted by greg on Wed, 01/28/2009 - 00:03

Issue ID:	1037
Issue Category:	bug
Component:	email
Priority:	normal
Status:	fixed
Assigned:	evan
Version:	0.7
Milestone:	1.0

When getting the email that someone new is listening to my notices I am not provided with the link to change my email settings. Example email:

Full Name (nickname) is now listening to your notices on Identi.ca.

http://their.url

Location: CO
Homepage: http://another.url
Bio: They say something about themselves.

Faithfully yours,
Identi.ca.

----
Change your email address or notification options at

That is it, it ends at the "at"

Legacy Data

This issue was migrated from another tracking system. The legacy data at time of import is provided below as a reference.

Ticket ID:

1037

Reported by:

greg

Owner:

evan

Status:

closed

Resolution:

closed

Type:

bug

Component:

Priority:

Version:

0.7

Milestone:

1.0

Updates

#1

Submitted by greg on Wed, 01/28/2009 - 00:06.

(Sorry about the description and the horizontal line, that came from the "----" in the email message)

Found the issue. Simple one line fix:

{{{
diff --git a/lib/mail.php b/lib/mail.php
index 5638ae9..1c6a10a 100644
--- a/lib/mail.php
+++ b/lib/mail.php
@@ -246,7 +246,7 @@ function mail_subscribe_notify_profile($listenee, $other)
"\n".'Faithfully yours,'."\n".'%7$s.'."\n\n".
"----\n".
"Change your email address or ".
- "notification options at %8$s\n"),
+ "notification options at ".'%8$s\n'),
$long_name,
common_config('site', 'name'),
$other->profileurl,
}}}

#2

Submitted by Evan Prodromou on Wed, 01/28/2009 - 10:30.

Thanks! Patched and pushed to identi.ca.

#3

Submitted by greg on Tue, 02/03/2009 - 02:12.

And my above patch includes a new very simple bug (my bad).

I had single quotes around the last /n instead of double quotes. This then ended the email with "Change your email address or notification options at http://identi.ca/settings/email\n"

If you need to see the diff, here it is:

{{{
diff --git a/lib/mail.php b/lib/mail.php
index b424d57..d822fe3 100644
--- a/lib/mail.php
+++ b/lib/mail.php
@@ -246,7 +246,7 @@ function mail_subscribe_notify_profile($listenee, $other)
"\n".'Faithfully yours,'."\n".'%7$s.'."\n\n".
"----\n".
"Change your email address or ".
- "notification options at ".'%8$s\n'),
+ "notification options at ".'%8$s'."\n"),
$long_name,
common_config('site', 'name'),
$other->profileurl,
}}}

Sorry 'bout that.