USER is a reserved keyword in SQL92, SQL99

USER is a resreved keyword in the SQL standard.

Using it as the name of the table for Laconica users obviously works fine in MySQL, but definitely breaks in PostgreSQL, and could cause problems in other places down the road.

(In theory you can just always enclose the tablename in quotes, but it appears that DB_DataObject doesn't do that, and it's probably kind of a pain anyhow.)

Changing the table name to "users" (plural) or lac_user or something else would, first of all, open the door to using Postgres, and would also likely also avoid other compatibility issues down the road.

--- Gotta patch, will integrate and test after version 0.5 -- evan July 11, 2008, at 04:15 PM

---

Requires patching actions/public.php actions/publicrss.php and the {databasename}.ini file that DB_DataObject uses and the classes/User.php and the db/laconica.sql for initial setup. For active installations would require an alter database to change the name for the existing user table and resetting foreign key constraints on the user_openid table, the confirm_address_table, and the remember_me table. Diffs using laconica_user as the table name have been emailed to Evan. Still to be done is the sql script to update existing database installations.