[rendering] URI linker includes non-URL characters in domains

Submitted by earle on Mon, 07/27/2009 - 12:13

Issue ID:	1743
Issue Category:	bug
Component:	core
Priority:	normal
Status:	active
Assigned:	evan
Milestone:	0.7
Keywords:	parser, URI

Such as @, [, ] and !.

http://identi.ca/notice/7094330

Legacy Data

This issue was migrated from another tracking system. The legacy data at time of import is provided below as a reference.

Ticket ID:

1743

Reported by:

earle

Owner:

evan

Status:

new

Type:

bug

Component:

core

Priority:

Version:

undefined

Milestone:

0.7

Attachment	Size
1743_any-length-endswith.diff	838 bytes

Updates

#1

Submitted by earle on Mon, 08/03/2009 - 16:31.

Apostrophes also. http://identi.ca/notice/4509587

#2

Submitted by narc on Tue, 11/10/2009 - 18:36.

As of StatusNet 0.8.2, auto-linkification would include a > character if present after a URL (see example at .

I've attached a proposed patch (any-length-endswith.diff) that would allow this situation to be caught and correctly handled by way of the $cannotEndWith array inside callback_helper() in lib/util.php.

A possibly better way would be to un-html-special-char the string before matching URLs, but that may very well not be an option -- this is a minimum-intrusion patch.