API and HTTP-AUTH

API and HTTP-AUTH

Submitted by macno on Wed, 01/20/2010 - 15:12
Issue ID:2165
Issue Category:bug
Component:api
Priority:normal
Status:fixed
Assigned:zach
Version:0.9
Milestone:0.9
Keywords:basic auth

When I call APIs sending basic auth, response should populate correctly the favorited/following values.

Actually it's done only if API is called without user id (ex http://identi.ca/api/friends_timeline.xml vs http://identi.ca/api/friends_timeline/user.xml )

Legacy Data

This issue was migrated from another tracking system. The legacy data at time of import is provided below as a reference.

Ticket ID: 
2165
Reported by: 
macno
Owner: 
zcopley
Status: 
closed
Resolution: 
closed
Type: 
bug
Component: 
api
Priority: 
3
Version: 
0.9
Milestone: 
0.9

Updates

#1

Submitted by macno on Wed, 01/20/2010 - 15:13.

This is my proposed fix

http://gitorious.org/~macno/statusnet/macno-apifix/commit/d491e451f85c82...

#2

Submitted by Zach Copley on Wed, 01/20/2010 - 22:13.

Nice fix. Thanks! I must have left that case out when I refactored the API. I had to alter your patch a bit, but it's in 0.9.x now:

http://gitorious.org/statusnet/mainline/commit/05156b708a16c5a20d4081242...

Do you mind using the Gitorious merge request feature for these kinda things?

#3

Submitted by macno on Thu, 01/21/2010 - 02:16.

Thanks!

Because this was my first code for sn project, I'd preferred to discuss it before request merge (BTW I wrote an email about it :) )

Login or Register to modify this issue, or to receive updates by email.

You can also subscribe to the RSS feed for updates to this issue.