Broken Reply button in search results

Submitted by Jeremy Pope on Sun, 07/15/2012 - 21:36

Issue ID:	3634
Issue Category:	bug
Component:	ui
Priority:	normal
Status:	active
Assigned:	Chimo
Keywords:	patch exists, searchbox, web interface

If you perform a search and attempt to reply to a notice, the textbox that appears doesn't render properly. Actually, all you can see is another searchbox. This bug seems to be affecting multiple instances including identi.ca.

See attached screenshots for examples.

Attachment	Size
searchbox.png	4.05 KB
searchbox1.png	47.03 KB

Updates

#1

Submitted by Chimo on Sun, 07/15/2012 - 22:59.

Merge request here: https://gitorious.org/statusnet/mainline/merge_requests/198

Note: I haven't re-minified the JS since I couldn't find documentation on how SN does it.

Details:
AJAX request url was "undefined" on the search page since there's no ".form-notice" (to initialize SN.C.I.NoticeFormMaster) and no "#form_notice" either on that page.

AJAX requests with "undefined" urls get the current page, from
which the first form in the document was taken. That turned out to be the search form, so it was cloned where the "reply" field should've been.

The fix uses the "#header-search"'s "action" attribute as a base url when ".form-notice" isn't present (like on the search page). It replace "/search/notice" with "/notice/new" and AJAX-fetches that page instead.