PATCH: Twitter settings page missing text in HTML title element

PATCH: Twitter settings page missing text in HTML title element

Issue ID:975
Issue Category:bug
Component:ui
Priority:normal
Status:fixed
Assigned:zach
Version:0.7
Milestone:1.0
Keywords:patch

When viewing one's Twitter settings page, the `title` element in the HTML output is missing some text. Specifically, the HTML code for the title is output as follows:

{{{
- Identi.ca
}}}

By comparison, see how the SMS Settings page title appears:

{{{
SMS Settings - Identi.ca
}}}

The title on the Twitter page therefore seems as though it should say, "Twitter Settings" or similar.

Legacy Data

This issue was migrated from another tracking system. The legacy data at time of import is provided below as a reference.

Ticket ID: 
975
Reported by: 
meitarm@gmail.com
Owner: 
zcopley
Status: 
closed
Resolution: 
closed
Type: 
bug
Component: 
ui
Priority: 
3
Version: 
0.7
Milestone: 
1.0
AttachmentSize
975_twitter-settings-title.git.patch365 bytes

Updates

#1

Easy fix; just a missing `return` statement. :)

#2

That was easy! Thanks.

#3

I noticed that this patch was applied to the Laconica repo. What's the appropriate process this project uses to close tickets on Trac? I.e., if I see a patch of mine applied, like this one, can I return to the ticket and close it or is there something else that needs to happen before tickets can be closed?

Thanks!

#4

You can just close it. We should probably have something hooked up to Trac that closes bugs automatically when patches are checked in.

Login or Register to modify this issue, or to receive updates by email.

You can also subscribe to the RSS feed for updates to this issue.