XMPP in_reply_to should be set to last notice that has been sent over XMPP

Submitted by Anonymous on Sun, 09/20/2009 - 11:45

Issue ID:	1884
Issue Category:	enhancement
Component:	api
Priority:	major
Status:	fixed
Assigned:	evan
Milestone:	0.9
Keywords:	context, xmpp

XMPP in_reply_to auto-guessing should only consider notices you have seen. Right now StatusNet can reply to a totally bogus notice and causing wrong in_context.

Consider the following scenario:

@alice sends a dent to !identica. This dent is sent to all in the identica-group. Then she writes another dent with some personal stuff.

@bob sees her !identica dent, but not her personal one (because he is in the identica group), and neatly replies @alice.

StatusNet will in the following situation put @bob's notice as a reply to @alice's private message. It should rather reply to the last notice from @alice that @bob saw.

Legacy Data

This issue was migrated from another tracking system. The legacy data at time of import is provided below as a reference.

Ticket ID:

1884

Reported by:

velmont

Owner:

evan

Status:

closed

Resolution:

closed

Type:

enhancement

Component:

xmpp

Priority:

Version:

undefined

Milestone:

0.9

Updates

#1

Submitted by Craig Andrews on Mon, 11/16/2009 - 13:13.

In 0.9, XMPP messages will show the notice_id in the [] after the message, ex: "Bob says hi! [78]"

I also added a "reply" command that you can use like this:
"reply 78 why hello Bob"

How does that solution sound?

#2

Submitted by BUGabundo on Mon, 11/16/2009 - 13:19.

Replying to [comment:3 candrews]:
> "reply 78 why hello Bob"
> How does that solution sound?

toooooo long.
how about
r ID ?

#3

Submitted by Craig Andrews on Mon, 11/16/2009 - 13:21.

"r" is a synonym for "reply" - you are welcome to use it.

#4

Submitted by voyagerfan5761 on Mon, 11/16/2009 - 13:40.

Replying to [comment:3 candrews]:
> In 0.9, XMPP messages will show the notice_id in the [] after the message, ex: "Bob says hi! [78]"
>
> I also added a "reply" command that you can use like this:
> "reply 78 why hello Bob"
>
> How does that solution sound?

It sounds great to me. With the synonym situation, it'll work quite well.

#5

Submitted by marjoleink on Thu, 04/07/2011 - 15:28.

Component:

xmpp

» api

It doesn't work as described:
- you need to add '#' in front of the notice_id (awkward - if an all-numeric user id isn't found assume it's a notice id)
- if 'r' is an alias it should be listed in the output of the 'help' command' (it isn't)
- the user being replied to isn't notified of this as a reply unless @username is also added
The real issue (wild guessing to whom/which dent a dent sent by XMPP may be a reply (if it is a reply at all!) has not been solved by adding a 'reply' command: it's still taking place and the guesses seem to be wilder than ever lately.

As to the last point, I'm collecting material and will create a separate new issue for that. But the wildest I saw (today) was a dent (reading actual context not a reply at all) being attached to a nine-month-old dent (by the account it was addressed to - at least it got that part right).

Conclusion: adding a reply command has made correct linkage possible (but not easy), and it's not a real solution anyway as the (wild) guessing is still taking place.