[ostatus] federated groups subscription - not all notices delivered
[ostatus] federated groups subscription - not all notices delivered
| Issue ID: | 3540 |
| Issue Category: | bug |
| Component: | ostatus |
| Priority: | critical |
| Status: | active |
| Assigned: | rozzin |
| Version: | 1.0 |
| Keywords: | federation, ostatus, patch exists |
subscribe to !feds.
you'll get posts only from people on your instance, or on parlementum (since parlementum hosts the group).
technically you'll get posts from anyone that anyone on your instance or on parlementum subscribes to.
[see here]
example threads:
http://march.status.net/conversation/1491#notice-1731
http://identi.ca/conversation/87286732
http://dent.gomertronic.com/conversation/26250
parlementum.net/conversation/560463/
Updates
#1
From http://tonybaldwin.me/status, I can mirror out to identi.ca, other feds, twitter, but am not receiving from identi.ca or twitter (but, yes, receiving from federated sites). I only see identi.ca dents if they are replies to me or other feds I follow, or another fed reposts.
#2
Is this patch (applies cleanly against at least StatusNet 1.0.1 and 1.1.0) sufficient to resolve this problem, or am I missing something more subtle?
#3
#4
Also, cf. issue #3638--if this bug is fixed but that one isn't, OStatus group-members might get a good deal more traffic than they were bargaining for.
#5
I have applied the patch on my instance (running mainline git). I have seen notices that I posted to groups on my instance are now pushed to and received on other instances by people who are subbed to the group but not to myself. Prior to applying the patch, this wasn't the case. It seems to be working well but, further testing on some of the larger instances may be needed.
#6
cf.: http://micro.jpope.org/conversation/180508
In particular, the posts that go from my instance (status.hackerposse.com) through the group on jpope's instance (micro.jpope.org) into group-member timelines on other `third-party' instances (e.g.: http://status.davidhaberthuer.ch/conversation/20057).
So, jpope-hosted groups are now actually doing what they're supposed to via OStatus--even when more than 2 sites are involved.
I believe that they're also not-doing things that they're not supposed to do, e.g.: I believe I got the logic right to avoid re-relaying posts that come in from remote groups and creating OStatus-storms.
#7
This is great, Joshua!
I will be looking through the code more thoroughly myself but by the quicks looks of it this is correct.
I wonder however whether there is a similar problem with ordinary conversations too and not just groups?
Are you a friend of git? I.e. http://status.net/wiki/Intro_to_using_git - in that case it would be awesome if you could do a merge request!
...bbl after some testing :)
#8
Let me know if I'm getting ahead of myself, but as I mentioned I experience this netsplit-like behaviour with conversations as well as groups. Should the same displaced isLocal() test perhaps be applied to replies further down in OStatusQueueHandler::handle() as well?
As a sidenote:
I think the dysfunctionality Joshua's patch addresses has been somewhat good to prevent spam from being spread like wildfire across all federated instances... But given that ActivitySpam etc. is starting to be used, this should not be a problem anymore. (Or rather: I prefer correct federation and then applying appropriate actions for spam-attacks).
#9
"It would be awesome if you could make this a merge request on Gitorious."
"Are you a friend of git? I.e. http://status.net/wiki/Intro_to_using_git - in that case it would be awesome if you could do a merge request!"
OK. Included in: https://gitorious.org/statusnet/mainline/merge_requests/201
I wouldn't say git and I are friends..., but I maintain all of the patches that I've applied to my sites in a ".git" directoy, e.g.: http://status.hackerposse.com/.git
#10
You can also subscribe to the
RSS feed for updates to this issue.