Failure to import twitter avatars with long extensions

I have been working quite a lot in modifying TwitterBridge and have come up with a solution that I'm currently using on freesocial.org

My TwitterBridge twitterimport.php file can be found at http://gitorious.org/~mmn/statusnet/freesocial/blobs/master/plugins/Twit...

* In function checkAvatar the filename construction is like this:
$path_parts = pathinfo($user->profile_image_url);
$ext = $path_parts['extension'];
$img_root = basename($path_parts['basename'], "_normal.{$ext}");
$newname = "Twitter_{$user->id}-original-{$img_root}.{$ext}";

* In function updateAvatar it's like this:
$path_parts = pathinfo($user->profile_image_url);
$ext = $path_parts['extension'];
$img_root = basename($path_parts['basename'], "_normal.{$ext}");
$url = $path_parts['dirname'] . "/{$img_root}_reasonably_small.{$ext}";
$filename = "Twitter_{$user->id}-original-{$img_root}.{$ext}";

This may differ from vanilla StatusNet as my Avatar fixes are also applied there:
https://gitorious.org/statusnet/mainline/merge_requests/186

...would you (and others) prefer my use of basename() or your patch if I make a merge request at Gitorious? .)

Hm, I'll have to look at how important the $pathparts['extension'] is in deciding.

From what I remember off the top of my head that's done using the MIME_Type class, which is much more accurate than trusting a file extension. But there's a risk there is some small snippets of code that have to be rewritten.

I'll see what I can do! .)

Hm I noticed however that my merge request doesn't handle the situation as it should when the extension is '.jpeg'

To do that the getMediatype() function must handle the '.jpeg' case next to the '.jpg'. (or the returned mediatype will be 'image/png').

Do you have any examples of Twitter users that have 'jpeg' extensions? I couldn't find any in my brief inspection.